Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support DeepSpeed >=0.6.0, <0.6.5 #13863

Merged
merged 8 commits into from
Jul 27, 2022
Merged

Support DeepSpeed >=0.6.0, <0.6.5 #13863

merged 8 commits into from
Jul 27, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Jul 26, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Fixes part of #13191

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @awaelchli @rohitgr7 @akihironitta @carmocca @justusschock @Borda

@carmocca carmocca added this to the pl:1.7 milestone Jul 26, 2022
@carmocca carmocca self-assigned this Jul 26, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 26, 2022
@carmocca carmocca changed the title Tests/update deepspeed lite Update Lite test to DeepSpeed >=0.6.0, <0.6.5 Jul 26, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jul 26, 2022
@carmocca carmocca mentioned this pull request Jul 26, 2022
Closed
@carmocca carmocca force-pushed the tests/update-deepspeed-lite branch from 811c432 to edff47c Compare July 27, 2022 00:16
@codecov
Copy link

codecov bot commented Jul 27, 2022 •
edited
Loading

Codecov Report

Merging #13863 (277630b) into master (fff62f0) will decrease coverage by 10%.
The diff coverage is 75%.

@@            Coverage Diff            @@
##           master   #13863     +/-   ##
=========================================
- Coverage      86%      76%    -10%     
=========================================
  Files         332      332             
  Lines       26127    26123      -4     
=========================================
- Hits        22481    19959   -2522     
- Misses       3646     6164   +2518

@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jul 27, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jul 27, 2022
@carmocca carmocca changed the title Update Lite test to DeepSpeed >=0.6.0, <0.6.5 Support DeepSpeed >=0.6.0, <0.6.5 Jul 27, 2022
@carmocca carmocca merged commit 511875e into master Jul 27, 2022
@carmocca carmocca deleted the tests/update-deepspeed-lite branch July 27, 2022 16:57
@carmocca carmocca removed the fabric lightning.fabric.Fabric label Jul 27, 2022
@awaelchli awaelchli mentioned this pull request Jul 27, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@akihironitta akihironitta Awaiting requested review from akihironitta

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

Assignees

@carmocca carmocca

Labels
pl Generic label for PyTorch Lightning package ready PRs ready to be merged strategy: deepspeed tests
Projects
None yet
Milestone
pl:1.7
Development

Successfully merging this pull request may close these issues.
4 participants
@carmocca @awaelchli @Borda @rohitgr7